This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(ui): bump @nextcloud/vue to ^8.39.0 (nav corner sliver on NC<34)#300
Merged
Conversation
Contributor
Quality Report — ConductionNL/softwarecatalog @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ❌ 2/775 denied | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
❌ Denied npm licenses
| Package | Version | License |
|---|---|---|
| pako | 1.0.11 | (MIT AND Zlib) |
| sha.js | 2.4.12 | (MIT AND BSD-3-Clause) |
Quality workflow — 2026-05-25 21:54 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@nextcloud/vuefrom^8.12.0to^8.39.0to fix a white-sliver UI bug in the navigation corner on Nextcloud < 34.Root cause
Nextcloud 34 introduced a rounded
.app-contentcorner treatment.@nextcloud/vueversions before 8.39.0 unconditionally rendered that NC34 rounded-corner styling, so on Nextcloud < 34 it produced a visible white sliver in the nav corner where the rounding did not match the host shell.@nextcloud/vue@8.39.0adds anisLegacy34guard that only applies the rounded-corner treatment on NC >= 34, eliminating the sliver on older Nextcloud versions.Changes
package.json: bumped the direct@nextcloud/vuedependency pin to^8.39.0. (No@nextcloud/vueentry exists inoverrides/resolutions, so only the direct dependency required a change.)package-lock.json: regenerated vianpm install --package-lock-only; resolves to8.39.0.The compiled bundle (
js/) is gitignored, so the only committed changes are the two manifest files.Part of a fleet-wide sweep to bump
@nextcloud/vueto^8.39.0across Conduction apps.